Refactor wp_parse_url to use WHATWG URL parser#12205
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Define WP_PARSE_URL_USE_WHATWG constant based on PHP version.
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
thanks for creating the PR. there’s less noise here than on Trac when updating patches, and it’s a bit easier to keep the discussion about the implementation/code separate from the goals in Trac.
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
left some comments on this, but also a discussion in Trac. for the code at hand, I would like to see us replace the function at initialization/parse time rather than at runtime during calls.
|
@dmsnell I am still learning some things with PHP, but hopefully I got your intention now. I know that the PR is not ready. It seems that we could use an internal helper function to just replace the moving parts, as there is code above and below that stays. And I'm not sure where to put the DocBlocks in such a case. WPCS in my editor is still complaining. Very excited if I am on track now :) |
2 participants
Refactor wp_parse_url to use WHATWG URL parser introduced in PHP 8.5.
Trac ticket: https://core.trac.wordpress.org/ticket/65448
Trac ticket: Core-65448
Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5 (Medium)
Used for: Implementation - reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.